Only compute ClientSideBaseVisitor
's fragmentsGraph
once, at instantiation time
#10019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #10018,
ClientSideBaseVisitor
'sfragmentsGraph
is implemented as a getter, despite not depending on anything that changes after the class is first instantiated. TurningfragmentsGraph
into a static property improved build time from ~130s to ~50s in a big monorepo.This PR does that and it makes field
fragmentsGraph
depends on (_fragments
) read-only to make sure we don't break the assumption behind pre-computing the former.Related: #10018
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate
How Has This Been Tested?
client-preset
and measure the build timefragmentsGraph
once perClientSideBaseVisitor
instanceTest Environment:
graphql
version: 16.2.0@graphql-codegen/client-preset
version(s): 4.2.6@graphql-codegen/visitor-plugin-common
version(s): 2.13.1Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...